Upgrade bundled/requested node version to 20.16.0 #18710
Draft
+45
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannon
changed the title
dannon
force-pushed
the
default-node-version-20
branch
from
c3f07b9
to
a06f5cf
Compare
dannon
force-pushed
the
default-node-version-20
branch
from
a06f5cf
to
4ff61c4
Compare
|
I think these 2 workflows should be updated too: galaxy/.github/workflows/jest.yaml Line 19 in 19bc932 galaxy/.github/workflows/js_lint.yaml Line 19 in 19bc932 |
Good call, missed those in the grep for the specific |
|
(draft while I tinker with github actions -- was trying to refactor so that we have a single setup-node composite action w/ a predefined or default version that we reuse, instead of copying it 10 times) |
dannon
force-pushed
the
default-node-version-20
branch
from
bff9d8c
to
83f05cd
Compare
See node release chart: https://nodejs.org/en/about/previous-releases Node 20 is the current "Active LTS" and will be so until node 22 enters active LTS later this fall.
dannon
force-pushed
the
default-node-version-20
branch
from
1cab715
to
ddd66bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades bundled/default node to the active LTS node v20. See release schedule here: https://nodejs.org/en/about/previous-releases
Node 18 is in maintenance mode for another 8 months or so, but by then 22 will be the active LTS.
Updates actions to use this. We could, instead, add multiple versions to the matrix but since we ship a specific version for compatibility we may just want to keep the tests focused?
How to test the changes?
(Select all options that apply)
License